Draft
Conversation
regexowl
force-pushed
the
update-validated-input-and-text-area
branch
2 times, most recently
from
b91f914 to
c5c1602
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4269 +/- ##
==========================================
- Coverage 71.52% 71.51% -0.02%
==========================================
Files 199 199
Lines 7526 7530 +4
Branches 2813 2820 +7
==========================================
+ Hits 5383 5385 +2
- Misses 1869 1871 +2
Partials 274 274
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This updates the component to behave the same as `ValidatedInput` - no validation rendered outside of the 'error' state and clear button rendered when there's a value. The validated inputs could and should be probably deduplicated, but the way they consume validation is not compatible so it might need to wait until after the revamp.
This updates the "Image details" step as per the revamp mocks. The "Author" field will be omitted for now as it would require updated in the backend.
regexowl
force-pushed
the
update-validated-input-and-text-area
branch
from
c5c1602 to
33179f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Image details step as per the revamp mocks.
A part of the revamp is also an update to the validated input component that is used on the Image details step - it now has a clear button and gets rendered as non-validated unless there's an error (no success state).